TF-3345 Fix sort order blinks when deleting emails in search #3437
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3437. |
tddang-linagora
approved these changes
Jan 21, 2025
hoangdat
reviewed
Jan 21, 2025
| @@ -666,7 +666,9 @@ class ThreadController extends BaseController with EmailActionController { | |||
| _searchEmailFilter.sortOrderType.isScrollByPosition(), | |||
| 0, | |||
| ), | |||
| beforeOption: const None(), | |||
| beforeOption: !_searchEmailFilter.sortOrderType.isScrollByPosition() | |||
| ? const None() | |||
There was a problem hiding this comment.
not a good idea in case:
- user search in a range of time, but when it refreshes,
beforeis not applied
There was a problem hiding this comment.
IMO, it still works correctly in this case. Please review the details.
There was a problem hiding this comment.
@hoangdat Please attach error video here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3345
Reproduce
demo.mov
Root cause
beforedate time is null when sort order by sender every time user refresh change emailResolved
demo.mov